Added support for Hotjar Events API. #660
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kacper-hotjar
approved these changes
Feb 15, 2022
juliomalegria
force-pushed
the
master
branch
from
bc0c117 to
e0a853d
Compare
chrisradek
approved these changes
Jun 2, 2022
Contributor
chrisradek
left a comment
chrisradek
left a comment
There was a problem hiding this comment.
@juliomalegria Thank you so much for the update and apologies for the delay in reviewing. This looks great, we'll merge it right away!
Contributor
|
Merging into feature branch - will create new PR from feature branch to trigger CI. Edit: PR to trigger CI - #677 |
chrisradek
added a commit
that referenced
this pull request
Jun 2, 2022
* Added support for Hotjar Events API. * Start passing properties() to the Event API * Updated tests to check track with/without properties Co-authored-by: julio.alegria <julio.alegria@hotjar.com> Co-authored-by: Ariel Silvestri <arielsilvestri0715@gmail.com> Co-authored-by: Julio M. Alegria <juliomalegria@users.noreply.github.com> Co-authored-by: julio.alegria <julio.alegria@hotjar.com> Co-authored-by: Ariel Silvestri <arielsilvestri0715@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds
tracksupport for Hotjar integration script (Hotjar Events API).Are there breaking changes in this PR?
No.
Testing
Testing completed successfully
Any background context you want to provide?
Hotjar now has an Events API. It will be beneficial for Segment and Hotjar users to be able to make use of it seamlessly.
Is there parity with the server-side/android/iOS integration components (if applicable)?
No
Does this require a new integration setting? If so, please explain how the new setting works
No
Links to helpful docs and other external resources
https://help.hotjar.com/hc/en-us/articles/4405109971095-Events-API-Reference